Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicated stack listing #120

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

katcipis
Copy link
Contributor

@katcipis katcipis commented Dec 29, 2021

On generation we are listing stacks twice unnecessarily (we can just use the metadata).

@katcipis katcipis requested a review from i4ki December 29, 2021 20:49
@katcipis katcipis self-assigned this Dec 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #120 (8c1a89e) into main (9b22eff) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   73.08%   73.20%   +0.11%     
==========================================
  Files          26       26              
  Lines        2731     2717      -14     
==========================================
- Hits         1996     1989       -7     
+ Misses        554      549       -5     
+ Partials      181      179       -2     
Flag Coverage Δ
tests 73.20% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metadata.go 100.00% <ø> (+3.33%) ⬆️
generate/generate.go 84.74% <100.00%> (+3.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b22eff...8c1a89e. Read the comment docs.

@katcipis katcipis changed the title fix: remove duplicated stack listing chore: remove duplicated stack listing Dec 29, 2021
Copy link
Contributor

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katcipis katcipis merged commit 5ee584f into main Dec 30, 2021
@katcipis katcipis deleted the katcipis-fix-duplicated-listing-generate branch December 30, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants